看到这么雷人的代码,真是悲催

确实雷到人了。也不说找个对象封装一下。

难道我就是传说的 被催 而强大的人...我真的怀疑是同事传的代码！！！

才 40-50个属性 不多，我们有个报表。。。80多个属性。。。。。

真的很悲催

没有注释真的好难看的懂啊。设计结构的时候有很严重的问题。。。

构造函数搞成这样真是有点郁闷，看的时候都不知道什么意思，后面新增字段的地方 还要回去修改这个代码。。。

这种代码不是用来看的...

看看我们的entity吧,很常见。不过参数还是起的好点，别人一眼也能看的懂
    /**
     * @ejb:command createGateLog
     */
    public GateLog create(
            int cmsNo,
            String cntrId,
            String tmlNo,
            String movementType,
            String movementCntrInterchangeMode,
            String movementRemark,
            String shipperConsignee,
            String billOfLadingNo,
            Timestamp movementCreatedDatetime,
            Timestamp movementPendingDatetime,
            Timestamp movementActiveDatetime,
            Timestamp movementHotDatetime,
            Timestamp movementConfirmDatetime,
            String bookingIndr,
            MultiSchemeCode bookingBlockInstructionCode,
            String bookingTrainCode,
            MultiSchemeCode bookingPortDischarge,
            String bookingPortDischargeName,
            MultiSchemeCode bookingPortDestination,
            String bookingPortDestinationName,
            String bookingRequestDtlPkeySeq,
            CntrLocation fromLocation,
            CntrLocation toLocation,
            String tractorCycleType,
            String cntrOnTractorPosition,
            MultiSchemeCode sizeTypeCode,
            int grossWeightDocumented,
            int grossWeightMeasured,
            String cntrStatus,
            String owner,
            String ownerRegion,
            String freightForwarderCode,
            String[] generalSeals,
            String[] customsSeals,
            String effTmlVoyidCompanyCode,
            String effTmlVoyidVesselCode,
            String effTmlVoyidVoyageCode,
            String effTmlVesselName,
            String effLineVoyidVesselCode,
            MultiSchemeCode portDischargeCode,
            MultiSchemeCode portLoadingCode,
            MultiSchemeCode portTransshipmentCode,
            MultiSchemeCode portFinalDestinationCode,
            MultiSchemeCode portOption1Code,
            MultiSchemeCode portOption2Code,
            MultiSchemeCode portOption3Code,
            MultiSchemeCode lineBlockInstruction,
            MultiSchemeCode linePortFinalDestination,
            MultiSchemeCode linePort1Optional,
            MultiSchemeCode linePort2Optional,
            MultiSchemeCode linePort3Optional,
            String thisGateinHoldList,
            String lastGateoutNextHoldList,
            String damageCodeSummary,
            String imcoCodeList,
            String undgCodeList,
            String localDgCategoryList,
            String requiredRfrTempWithUnit,
            String gateinRfrTempWithUnit,
            String[] specialHandleCodes,
            String[] equipmentCodes,
            String permitCargoPermit,
            String duitableCargoPermit,
            int maxGrossWeight,
            String detentionStatus,
            String detentionDayIndr,
            String lineInstructionType,
            String lineInstructionReference,
            Timestamp lineInstrnEffectiveStartDt,
            Timestamp lineInstrnEffectiveEndDt,
            String lineInstrnAcceptedByActor,
            String lateComeInstructionPKSeq,
            String lcOrigTmlVoyidCompanyCode,
            String lcOrigTmlVoyidVesselCode,
            String lcOrigTmlVoyageCode,
            String transportMode,
            String trainId,
            String trainWagonNo,
            String tractorNo,
            String documentPrintableTractorNo,
            String tractorCompanyCode,
            String tractorCompanyName,
            String tractorCardId,
            String tractorDriverId,
            String tractorDriverName,
            String origTractorNoBeforeSwap,
            Timestamp tractorGateInDatetime,
            Timestamp tractorGateOutDatetime,
            String emptyPickupMode,
            boolean empkXgateAlwDamageOutIndr,
            String[] empkXgateDisalwDmgOutCodes,
            int empkCritGrossWt,
            String empkCritGrWtSelModifier,
            String empkCritCntrMaterial,
            String empkCritCntrTypeGp,
            String empkCritCntrIdPattern,
            String empkCritOutboundRegionCode,
            String empkCritHoldCondition,
            String empkCritHoldPort,
            String empkCritDamageSelectMode,
            String[] empkCritDmgButExcludeCodes,
            String[] empkCritSpHdlCodes,
            String[] empkCritEquipmentCodes,
            CntrLocation empkDeliveryLocn,
            String emptyGrndProblemReasonCode,
            boolean deleteIndr,
            String deleteActor,
            String deleteReason,
            Timestamp deleteDatetime,
            String preadviceIndr,
            boolean isTerminalReceiptPrinted,
            String cmsPrintByActor,
            String[] discrepancyGeneralSeals,
            String[] discrepancyCustomsSeals,
            String empkCritNomEmPoolCode,
            String empkCritReeferCondition,
            String empkCritReqRfrTempUnit,
            double empkCritReqRfrTemperature,
            boolean isEmpkCritRfrInRefigIndr,
            String empkCritOwnerSelectMode,
            String empkCritEffOwnerGnlEmSrh,
            String gateOutConfirmedByActor,
            String effLineVoyIdVoyageCode,
            String eqexInstructionType,
            String eqexReferenceNo,
            int eqexVersionNo,
            String gateMvtRecvCreatedByActor,
            String trtActualGateInTmlId,
            String trtActualGateInLsLocnType,
            String trtActualGateInLsLevel1,
            String trtActualGateInLsLevel2,
            String trtActualGateInLsLevel3,
            String trtActualGateInLsLevel4,
            String trtActualGateOutTmlId,
            String trtActualGateOutLsLocnType,
            String trtActualGateOutLsLevel1,
            String trtActualGateOutLsLevel2,
            String trtActualGateOutLsLevel3,
            String trtActualGateOutLsLevel4,
            String trtPreferGateOutTmlList,
            String[] currentHolds,
            String[] damageCodes,
            String tmlIoReferenceOwner,
            String lineShippingOrderNo,
            String tmlBookingNo,
            String earlyComeInstructionPKSeq,
            String portSecurityCouponNo,
            int cntrReturnDurationDay,
            String freightForwarderRemark,
            String[] dispatchedSeals,
            String visitNo,
            String tmlServiceAttendingMode,
            String iocGrndingReferenceNo,
            String tractorNoShortkey,
            String requiredRfrVentWithUnit,
            String empkCritCntrIdPatternMode,
            String empkCritCntrIdSelModifier,
            String empkCritDamageSelModifier,
            int grossWeightReferenced,
            String grossWeightDocumentedSrcPt,
            String empkRtnEffUnavailAreaIndr,
            String empkRtnSearchPhase,
            String empkRtnWorkloadStatus,
            String empkRtnYcExistIndr
            ) throws CreateException,RemoteException;

这个悲催吗,存储过程50多个参数的一堆

人类已经无法阻止他了